Skip to content

[LIBCLOUD-751] Add tests in Point DNS provider for Redirects and Mail… - #591

Closed
aleGpereira wants to merge 1 commit into
apache:trunkfrom
aleGpereira:LIBCLOUD-751_pointsdnstests
Closed

[LIBCLOUD-751] Add tests in Point DNS provider for Redirects and Mail…#591
aleGpereira wants to merge 1 commit into
apache:trunkfrom
aleGpereira:LIBCLOUD-751_pointsdnstests

Conversation

@aleGpereira

@aleGpereira aleGpereira commented Sep 30, 2015

Copy link
Copy Markdown
Contributor

…Redirects classes

@asfgit asfgit closed this in 58c4ec9 Oct 3, 2015
@Kami

Kami commented Oct 3, 2015

Copy link
Copy Markdown
Member

I made a change to the PointDNSException class so it inherits from ProviderError which is intended to be used for that purpose - 0855665. I also updated the constructor signature so it matches the parent one.

For the future reference - this class doesn't really provide additional value over the existing ProviderError one (all the information is already available via ProviderError class) so there is little value in adding / having it.

Besides that the changes look good so I've merged it into trunk.

Thanks.

Kami
Kami reviewed Oct 3, 2015
View reviewed changes
Comment thread libcloud/dns/drivers/pointdns.py

@Kami Kami Oct 3, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another "for the future reference" - Ideally those exceptions would be handled on the Response class - see how other classes use set_context method.

@aleGpereira

aleGpereira commented Oct 4, 2015

Copy link
Copy Markdown
Contributor Author

Yeah, you're right. My intention only was to specify the provider. If for some reason someone needs to catch an exception only for pointdns, can use it. But, yeah. Is just a little thing.

@aleGpereira

aleGpereira commented Oct 4, 2015

Copy link
Copy Markdown
Contributor Author

Thanks for the merges!

@aleGpereira
aleGpereira deleted the LIBCLOUD-751_pointsdnstests branch October 12, 2015 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aleGpereira @Kami